Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: break if no result for getFormState #12691

Closed
wants to merge 3 commits into from
Closed

Conversation

zfben
Copy link

@zfben zfben commented Dec 9, 2024

Changes

Fix when no this.result.

Testing

It doesn't change api, just check the property.

Docs

Not affect users' behavior, so don't need to update docs.

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 45f3753

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Dec 9, 2024
@ematipico
Copy link
Member

Can we add a test that shows we fixed a bug?

@zfben
Copy link
Author

zfben commented Dec 9, 2024

Can we add a test that shows we fixed a bug?

I don't know how to add a test case to reproduce this bug, it breaks my project and I found the code causing it.

@florian-lefebvre
Copy link
Member

@zfben can you create a minimal reproduction for this? This way we could extract a test case from it

@florian-lefebvre florian-lefebvre added the needs response Issue needs response from OP label Jan 9, 2025
@zfben
Copy link
Author

zfben commented Jan 14, 2025

@zfben can you create a minimal reproduction for this? This way we could extract a test case from it

I forgot how it happens, just remember that render a page with just a react component and in middleware mode, it breaks. but it works when using client:only.

My project has skippied this bug, so i don't know how to reproduction it again.

@florian-lefebvre
Copy link
Member

Well I'm going to close this PR then. Thanks for trying! If you ever face this problem again, please open an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs response Issue needs response from OP pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants