Fix Vue & Svelte server renderer types #12776
Merged
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using Astro's container API outside of vite/vitest, renderers have to be manually imported and stored inside the container (as per docs).
However, importing the Vue and Svelte server renderers results in a Typescript error:
This PR fixes the Vue & Svelte server renderer types (
server.d.ts
) to be more in line with React's types and fix the Typescript errors.Testing
This was tested with a local project using the above code snippets.
(Could a test be written for the types?)
Docs
No documentation change needed as far as I can tell.