fix(alpinejs): start on DOMContentLoaded #13014
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da02e03 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
/snapshot alpine-scripts |
|
I created a temporary PR at #13030 because we can't make snapshot releases from forks. Keep this one tho! |
1 task
florian-lefebvre
approved these changes
Jan 22, 2025
florian-lefebvre
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #12710 (comment).
Externally loaded AlpineJS component scripts were loaded after
Alpine.start()was triggered. Issue started with Astro V5.Changes
Alpine.start()on theDOMContentLoadedevent. According to MDN documentation (https://developer.mozilla.org/en-US/docs/Web/API/Document/DOMContentLoaded_event),DOMContentLoadedfires immediately after HTML and deferred scripts are loaded. In short, this change guarantees thatAlpine.start()is only called after all scripts are loaded.Testing
Docs