New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move node adapter to core #13141

Merged

ematipico merged 497 commits into main from move-node

Feb 6, 2025

Member

ematipico commented Feb 5, 2025 •

edited

Loading

Changes

This PR starts a series of PR that will move the adapters pack into the main monorepo.

I fixed the build step and the tests.

Steps to keep the history:

Checkout the adapters repository into a temporary folder

Run

git filter-repo --path packages/node --path-rename packages/node:packages/integrations/node

Move to this repository and create a new branch move-node
Add the temporary folder to the list of remotes of withastro/astro, called adapters

Run

git pull --allow-unrelated-histories --no-rebase  adapters main

Resolve conflicts
Fix CI

Testing

I had to skip two tests regarding the infer remote size. We would need to fix and enable them.

The CI should pass.

Docs

withastro/docs#10898

natemoo-re and others added 30 commits

August 10, 2023 18:25


          [ci] format

493c6dd


          [ci] release (beta) (#7952)

0354d3e

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (#8023)

f1a776e

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (#8043)

81269c6

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (beta) (#8067)

578357a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          Merge remote-tracking branch 'origin/main' into next

f1c1c99


          Stream request body instead of buffering it in memory (#8084)

6dbf433

Co-authored-by: Matthew Phillips <matthew@matthewphillips.info>


          [ci] release (#8064)

9c0da3f

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (#8090)

3f36011

* [ci] release

* Update packages/create-astro/CHANGELOG.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>


          feat: unflag experimental.assets (#7921)

f6e9890

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>


          Prerendering corner cases (#8070)

fe2a58b

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>


          [ci] format

31fb92c


          Merge branch 'main' into next

7f978ec


          Switch build.inlineStylesheets default to auto (#8118)

5b92486

* switch inlineStylesheets default

* use previous default for astro/test

* use previous default for content-collections-render.test.js

* integrations: node, deno, mdx, markdown

* typedocs: switch inlineStylesheets default

* Update example to show non-default

* add changeset

* reword changeset

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>


          [ci] release (#8096)

c785e67

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (#8138)

af9bcab

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (beta) (#8073)

aa7c00c

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          [ci] release (beta) (#8140)

2b9f1ed

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          fix(node): delegate preview's not found and error handling to core/app (

bed930a

#8141)

* fix(node): delegate preview's not found and error handling to core/app

* add changeset

---------

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>


          [ci] release (#8145)

07faa9a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          Merge remote-tracking branch 'origin/main' into next

82f9724


          fix(@astrojs/node): handler should work with express (#8176)

6f84e2a


          Merge remote-tracking branch 'origin/main' into next

a8adeea


          [ci] release (rc) (#8147)

be25490

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          Add h3 for Installing dependencies manually (#8155)

f904f9a


          Update non-major dependencies (#8199)

77a4e8f


          [ci] release (#8172)

b0997b5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          Update breaking dependencies (#8201)

8aa31d9


          Merge remote-tracking branch 'origin/main' into next

b37f076


          [ci] release (#8205)

36963e6

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ematipico and others added 12 commits

November 28, 2024 13:25


          Merge pull request #451 from withastro/next

b6d84ea


          [ci] release (#448)

7425dbb

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          test: use Astro v5 and update cloudflare assertions (#460)

a5803c7

* test: use Astro v5 and update cloudflare assertions

* disable check origin

* disable check origin

* update test

* fix another test

* remove logging

* format


          test(node): add image tests (#459)

a1edab6

* chore(node): add image tests

* Format

* Format


          refactor: readability (#463)

c19ba1c


          fix(deps): update all non-major dependencies (#457)

f6989c7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: bluwy <bjornlu.dev@gmail.com>


          [ci] release (#497)

63dfbff

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          fix(deps): update all non-major dependencies (#503)

90bb351


          fix: correctly handle wildcard hosts in preview (#514)

bce2964


          [ci] release (#507)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>


          chore(node): add tests for preview host (#518)

0f3e23b

* Add tests

* Format


          Merge branch 'main' of ../../temp/adapters into move-node

43a37c1

changeset-bot bot commented Feb 5, 2025 •

edited

Loading

⚠️ No Changeset found

Latest commit: 9f54f0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions bot added the pkg: integration label

ematipico added 3 commits

February 5, 2025 16:28


          fix: deps and test utils

b91c35a


          fix: tsconfig

d04177d


          fix: tests and skip few of them

9f54f0e

ematipico marked this pull request as ready for review

February 6, 2025 11:12

Adammatthiesen commented Feb 6, 2025

Why is it coming back? Didn't they all just get their own repo not to long ago?

Member Author

ematipico commented Feb 6, 2025 •

edited

Loading

Why is it coming back? Didn't they all just get their own repo not to long ago?

In September, during our offsite, the core team decided that having them inside core was better. While the adapters were in a different repository, we experienced the following difficulties:

regressions that we couldn't catch early
test the adapters against the core code pushed in main and next for major releases

These regressions took huge toll to the maintainers, and we eventually realised that we made a mistake in the first place, so now we bring them back into the main monorepo.

Sure, we will have more issues filed, but a trade-off we are willing pay.

Adammatthiesen commented Feb 6, 2025

Why is it coming back? Didn't they all just get their own repo not to long ago?

In September, during our offsite, the core team decided that having them inside core was better. While the adapters were in a different repository, we experienced the following difficulties:

regressions that we couldn't catch early

test the adapters against the core code pushed in main and next for major releases

These regressions took huge toll to the maintainers, and we eventually realised that we made a mistake in the first place, so now we bring them back into the main monorepo.

Sure, we will have more issues filed, but a trade-off we are willing pay.

Makes sense, thanks for the clarification!

Member

sarah11918 commented Feb 6, 2025

Reminder that moving the adapters is a non-trivial docs change, too! We pull information about the adapters into each docs page from its repository... so if you're changing that, we need to know and update our docs infrastructure!

Member Author

ematipico commented Feb 6, 2025 •

edited

Loading

@sarah11918 ~~if you let me know where the code is, I can help and send a PR~~ PR sent

ematipico mentioned this pull request

chore: update github node adapter URL withastro/docs#10898

Merged

Member

sarah11918 commented Feb 6, 2025

Thanks! I was conferring with Chris to make sure nothing else relied on the adapter repo, but since we did restructure to use the full GitHub URL, looks like it was a trivial change! 🙌

Contributor

ascorbic commented Feb 6, 2025

Thanks for including the details on how it was done!

ascorbic approved these changes

View reviewed changes

ascorbic mentioned this pull request

feat: add support for automatic session driver config #13145

Merged

ematipico merged commit df7eb74 into main

15 checks passed

ematipico deleted the move-node branch

February 6, 2025 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration

29 participants