Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print snapshot release error output #13151

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: print snapshot release error output #13151

merged 1 commit into from
Feb 7, 2025

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 7, 2025

Changes

Currently if the snapshot release fails it doesn't log anything, beacuse we redirect the output so we can include it in the comment. This PR changes it to use tee so that it logs it as well. It also uses the captured output to comment with an error if it fails

Testing

lol it's a GH action. Nobody knows how to test those

Docs

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: c08d6e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Feb 7, 2025
@ascorbic ascorbic merged commit 8b223ee into main Feb 7, 2025
14 checks passed
@ascorbic ascorbic deleted the echo-snapshot branch February 7, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants