-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build to a single file #2873
Merged
Merged
Build to a single file #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84b3977 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Related to the core `astro` package (scope)
test
labels
Mar 24, 2022
matthewp
commented
Mar 24, 2022
matthewp
commented
Mar 24, 2022
matthewp
commented
Mar 24, 2022
matthewp
commented
Mar 24, 2022
matthewp
force-pushed
the
single-file-build-3
branch
from
March 24, 2022 15:14
a2e454b
to
030c302
Compare
matthewp
force-pushed
the
single-file-build-3
branch
from
March 24, 2022 17:24
e587f9d
to
d63a4cb
Compare
Can't seem to leave a review right now, but looks good! Saw one stray
|
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Build to a single file * Updates based on initial code review * Adds a changeset * Use the default export for cjs module * Await generatePages * Prevent timing from causing module to not import * Fix shared CSS * Properly handle windows ids * Dont shadow * Fix ts errors * Remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
facadeId
maps in the internals module. Instead we put metadata about a route in the existingBuildPageData
object.vite-plugin-pages
is the entry module for the build. It imports all routes and prepares itself for static rendering / ssr.vite-plugin-ssr
is the entry for SSR. It imports the vite-plugin-pages module and implements the adapter API.Testing
Docs
Not yet, separate issue.