-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: remaining integration READMEs #2885
Conversation
🦋 Changeset detectedLatest commit: 428f32f The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look great!
Not blocking, but I'd consider moving the Getting Started sections above Installation? For someone unfamiliar with what these tools do, they probably want a description of the tool before deciding to install it.
@natemoo-re So fair point, but I'm not sure the getting started calls-to-action make sense at the beginning? For instance, asking users to "try navigating between different pages via links" for Turbo won't work until the installation step. I think the one-liners at the top of the README are sufficient to understand what the tool does 🤷 Ex.
|
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Changes
@astrojs/partytown
@astrojs/tailwind
@astrojs/turbolinks
@astrojs/sitemap
Testing
Docs