Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove rss helper from getStaticPaths #3462

Merged
merged 5 commits into from
May 31, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented May 27, 2022

Changes

  • Remove rss() functionality from getStaticPaths. Calling rss now logs an error pointing to new @astrojs/rss documentation
  • Remove all dead RSS code from astro core
  • Remove fast-xml-parser from core deps

Testing

Making sure nothing breaks!

Docs

withastro/docs#679

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

🦋 Changeset detected

Latest commit: 4d0fd62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 27, 2022
@aFuzzyBear
Copy link
Contributor

Lets do this, its been a few versions since rss was moved into its new home,

@bholmesdev bholmesdev merged commit d145b86 into main May 31, 2022
@bholmesdev bholmesdev deleted the chore/remove-rss-helper branch May 31, 2022 16:08
@github-actions github-actions bot mentioned this pull request May 31, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* chore: remove rss() with helpful error message

* docs: add context on "getStaticPaths" removal

* chore: changeset

* deps: remove fast-xml-parser from core!

* chore: update lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants