Fix importing CSS packages in frontmatter #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25d92eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
tony-sull
approved these changes
Jun 6, 2022
Merged
5 tasks
1 task
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Fix importing CSS packages in frontmatter * Formatting * Only update if the source code contains the import * Consolidate the two plugins * we do need a pre and a post * Adds a changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vite:css-postremoves JS modules that only contain CSS. These modules only exist so that the CSS asset can be created. Vite removes them and updates import statements to also be removed.import * as $$module from 'some/package';which is used to discover if the package contains used web components. Because of these namespace imports, those don't get removed by vite:css-post.Testing
@fontsource/*package since those are a bit popular.Docs
N/A, bug fix.