Add private addPageExtension hook
#3628
Conversation
|
github-actions
bot
added
the
pkg: astro
| // Otherwise, create a unique id for this set of hoisted scripts | ||
| moduleId = `/astro/hoisted.js?q=${uniqueHoistedIds.size}`; | ||
| uniqueHoistedIds.set(uniqueHoistedId, moduleId); | ||
| if (metadata) { |
There was a problem hiding this comment.
All this noise is just moving anything that accesses metadata inside an if (metadata) block. With custom pages, metadata might not be defined.
| if (!Component.isAstroComponentFactory) { | ||
| const props: Record<string, any> = { ...(pageProps ?? {}), 'server:root': true }; | ||
| const html = await renderComponent(result, Component.name, Component, props, null); | ||
| page = { | ||
| type: 'html', | ||
| html: html.toString() | ||
| } |
There was a problem hiding this comment.
If the module exports a non-astro file, we pass it through our component pipeline instead, which will use any provided renderers to render the component
| // Semi-private `addPageExtension` hook | ||
| Object.defineProperty(hooks, 'addPageExtension', { | ||
| value: (...input: (string|string[])[]) => { | ||
| const exts = (input.flat(Infinity) as string[]).map(ext => `.${ext.replace(/^\./, '')}`); | ||
| updatedConfig._ctx.pageExtensions.push(...exts); | ||
| }, | ||
| writable: false, | ||
| enumerable: false | ||
| }) |
There was a problem hiding this comment.
Not that private, but it works! It is intentionally not enumerable or exposed in the types, only there if you're looking for it.
| if (isPage) { | ||
| return html; | ||
| } |
There was a problem hiding this comment.
For hydration to work, we need to avoid stripping out astro-fragment on the top-level page, so we inject a server:root prop to track that.
natemoo-re
force-pushed
the
feat/page-extensions
branch
from
8b8e61b
to
ee798ce
Compare
natemoo-re
changed the title
addPageExtensions hookaddPageExtension hook
|
I think I know what this is for...
|
| @@ -57,46 +57,54 @@ export async function staticBuild(opts: StaticBuildOptions) { | |||
| const [renderers, mod] = pageData.preload; | |||
| const metadata = mod.$$metadata; | |||
|
|
|||
| // Track client:only usage so we can map their CSS back to the Page they are used in. | |||
| const clientOnlys = Array.from(metadata.clientOnlyComponentPaths()); | |||
There was a problem hiding this comment.
There's going to be merge conflicts after #3625 is merged. However all of this code goes away, so I think your changes won't be needed.
There was a problem hiding this comment.
Yep, noticed this! Was glad to see this going away.
natemoo-re
force-pushed
the
feat/page-extensions
branch
from
ee798ce
to
fcd240c
Compare
* feat: add private `addPageExtensions` hook * chore: remove renderer binding Co-authored-by: Nate Moore <nate@astro.build>
Changes
addPageExtensionhook to integrationsTesting
Test added
Docs
Not a public change