Inline small hoisted scripts #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce7aa13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
I need to verify that this doesn't break hoisted scripts that have imports to shared chunks. |
This makes it so that small hoisted scripts get inlined into the page rather than be fetched externally.
matthewp
force-pushed
the
inline-hoisted-scripts-now2
branch
from
436da5d
to
8308cf1
Compare
Done |
FredKSchott
reviewed
Jun 21, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Inline small hoisted scripts This makes it so that small hoisted scripts get inlined into the page rather than be fetched externally. * Ensure we don't inline when there are imports * Fix ts * Update tests with new url structure * Adds a changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vite.build.assetInlineLimit(default 4096 bytes) to determine whether to inline.Testing
Docs
N/A, perf improvement.