Add @nanostores/preact to ALWAYS_NOEXTERNAL
#3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 556017e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
changed the title
@nanostores/preact to ALWAYS_NOEXTERNAL
github-actions
bot
added
the
pkg: astro
bholmesdev
force-pushed
the
chore/add-nanostores-to-always-no-external
branch
from
cbefaf2
to
556017e
Compare
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* chore: add nanostores/preact to ALWAYS_NOEXTERNAL * chore: update comment to reference pR * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
@nanostores/preactto the dreadedALWAYS_NOEXTERNALlist.It seems
noExternalis required for any utility package relying on Preact hooks. From testing, this is likely due to a duplicate Preact getting bundled when used in a component, with a separate Preact coming from yournode_modulesinside the offending package.Why not
@nanostores/react?React is a UMD package, while Preact is a true ESM package. This means React will always be bundled due to Vite's heuristics, while Preact will be ignored. This is why
resolve.dedupedoes not solve the issue for Preact 😓Testing
N/A, though a "nanostores" E2E test suite is on my list!
Docs
N/A