Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all client build artifacts in SSRManifest #3678

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: f2f4245

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 22, 2022
@nrgnrg
Copy link
Contributor

nrgnrg commented Jun 22, 2022

would this also resolve #3668 by any chance?

@matthewp
Copy link
Contributor Author

@nrgnrg I'm not sure. It might, but I don't know enough about how partytown works. Can try when the release is out.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewp matthewp merged commit 8988454 into main Jun 22, 2022
@matthewp matthewp deleted the ssr-manifest-regression branch June 22, 2022 15:35
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Include all client build artifacts in SSRManifest

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 1.0.0-beta.48 regression in SSRManifest
3 participants