Remove second snowpack instance

[matthewp]

Changes

This gets rid of having 2 snowpack instances. Instead there's just one, but no more import.meta.env.astro. So this is a breaking chance.

People can use import.meta.env.SSR for the same purpose.

Testing

• [✅] Tests are passing
• [✅] Tests updated where necessary

Docs

This wasn't documented, I'm adding it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 300b9e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/astro-www/8PmkjRMjMe93kJQwsHrcFZrJ5deQ
✅ Preview: https://astro-www-git-there-can-be-only-one-snowpack-pikapkg.vercel.app

[matthewp]

Closes #357

[FredKSchott]

Oh my god this just feels so much better! Output looks good and feels faster too.

Saw one issue when running this on snowpack.dev main branch:

[build] Error: Error: No renderer found for PluginSearchPage:load! Did you forget to add a renderer to your Astro config?
    at file:///Users/fks/Code/astro/packages/astro/src/build/page.ts:98:44
    at async Promise.all (index 0)
    at buildStaticPage (file:///Users/fks/Code/astro/packages/astro/src/build/page.ts:96:3)
    at file:///Users/fks/Code/astro/packages/astro/src/build.ts:78:9
    at async Promise.all (index 30)
    at build (file:///Users/fks/Code/astro/packages/astro/src/build.ts:75:5)
    at buildAndExit (file:///Users/fks/Code/astro/packages/astro/src/cli.ts:16:15)

[FredKSchott]

Also HMR is no longer connecting in dev, also on the Snowpack repo (seems to be trying to connect to localhost:3000)

[matthewp]

@FredKSchott maybe you can show me how you're running a local copy of astro in that repo. I haven't been able to get it to work.

[matthewp]

HMR issue is unrelated to this change. Fixed it here: #375

[matthewp]

Ok, that took longer that it should have. @FredKSchott reason that component throws is because it depends on the very env variable that this PR removes support for. So changing it to use import.meta.env.SSR instead fixes it.

[drwpow]

Maybe remove the Promise.all() ? Unless we need to add more cleanup relatively soon

[matthewp]

oh yeah good point

[drwpow]

🎉 🎉 🎉

[drwpow]

.changeset/rare-nails-sneeze.md 🤨

[FredKSchott]

LGTM! Plz run it on snowpack.dev if you can to confirm

[matthewp]

@FredKSchott Yep, I did, that's what this comment was in reference to: #368 (comment)

I'll update snowpack.dev once this is released.