-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Astro.redirect use a 302 status code #3700
Conversation
🦋 Changeset detectedLatest commit: 86cc2cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,3 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a callout on test fixtures going forward: due to a new noExternal
dependency in Vite 3, we'll need to include a package.json
with astro
as a dependency for every test suite. Otherwise, Vite will fail to pre-bundle Astro. I'd recommend adding a package.json
for this new suite as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests are passing!
* Make Astro.redirect use a 302 status code * Adds a changeset * Add a package.json
Changes
Testing
Docs
N/A