-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: remove memory test from CI #3758
Conversation
🦋 Changeset detectedLatest commit: db8802c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If it’s not bothering anyone, can we leave the script in the repo? I remember this randomly being useful a couple of times when I was tracking down perf issues. |
@FredKSchott This test is breaking Vite 3 (see PR comments) but maybe we can refactor to use |
It’s not just a test! You can run the script yourself and it starts in a “watch” mode. To be super clear, +1000 on removing from CI. But would love to keep the script for personal/maintainer use |
@FredKSchott Ah gotcha! Removing from the CI would be perfect, yes 👍 |
This reverts commit 31b97c9.
Update: looks like manually running outside the CI also breaks with Vite 3... experimenting with a refactor to use Second update: Vite might be removing this hard bomb from Vite 3. Logged an issue for discussion. Removing this test from our CI for now though since y'all agree! |
Changes
Remove our memory smoke test from CI only (test still present and manually runnable)
Why?
astro
package to force-optimize dependencies. Since this test imports and calls thedev
command directly (rather than usingexeca
), Vite fails to resolveastro
as an installed dependency. We can refactor this test to useexeca
instead if we feel this test is necessary!Testing
Remove
mk.js
+ command call from the CIDocs
N/A