-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDX] Support remark and rehype plugins, with defaults #3977
Conversation
🦋 Changeset detectedLatest commit: e168675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, waiting on @sarah11918 for copy edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with more markdown => Markdown
nits
packages/integrations/mdx/test/fixtures/mdx-remark-plugins/src/pages/with-gfm.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
bbce057
to
e168675
Compare
LGTM, @bholmesdev ! |
Changes
remarkPlugins
andrehypePlugins
config options{ extends: [...] }
Testing
Add integration tests for GH-flavored markdown and applying a custom plugin (remark-toc).
Docs
TODO: readme updates