Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes warnings / flags for integrations and ssr #3992

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Removes warnings / flags for integrations and ssr #3992

merged 1 commit into from
Jul 20, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes flags for SSR and integrations.
  • Removes restrictions on 3rd party usage.
  • Removes warnings.

Testing

  • Tests updated

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

🦋 Changeset detected

Latest commit: 00817b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Minor
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 20, 2022
natemoo-re
natemoo-re approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bholmesdev
bholmesdev approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SS renderer is ready to set sail 🚢

@matthewp matthewp merged commit ccae431 into main Jul 20, 2022
@matthewp matthewp deleted the remove-lame-warnings branch July 20, 2022 19:52
@astrobot-houston astrobot-houston mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @natemoo-re @bholmesdev