[MDX] Add Prism and Shiki support #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ab7794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bholmesdev
commented
Jul 21, 2022
| if (key === 'className') { | ||
| return markHTMLString(` class="${toAttributeString(value, shouldEscape)}"`); | ||
| } | ||
|
|
There was a problem hiding this comment.
TODO: remove changes when blocking draft PR is ready!
There was a problem hiding this comment.
@bholmesdev should be good to remove this now!
bholmesdev
commented
Jul 21, 2022
| @@ -134,6 +134,42 @@ const posts = await Astro.glob('./*.mdx'); | |||
| ))} | |||
| ``` | |||
|
|
|||
| ### Syntax highlighting | |||
There was a problem hiding this comment.
Tagging @sarah11918 for proofing!
sarah11918
reviewed
Jul 21, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
YESSSSSSS, LETTTSS GOOOOOOO |
natemoo-re
approved these changes
Jul 21, 2022
This reverts commit 07f4528.
github-actions
bot
removed
the
pkg: astro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
shikiis configuredprismis configuredTesting
Test Shiki, Shiki config options, and Prism ->
mdx-syntax-highlighting.test.jsDocs
Add "Syntax Highlighting" section to README