Fix: use set:html when markdown mode is md
#4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f9a1bbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
changed the title
set:html when markdown mode is _not_ mdxset:html when markdown mode is md
github-actions
bot
added
pkg: astro
bholmesdev
commented
Jul 21, 2022
Comment on lines
-96
to
-98
| .use(rehypeEscape) | ||
| .use(rehypeIslands) | ||
| .use([rehypeCollectHeaders]) |
There was a problem hiding this comment.
All JSX or Astro component specific! Move under isMDX flag.
bholmesdev
commented
Jul 21, 2022
Comment on lines
-49
to
-50
| .use(isMDX ? [remarkMdxish, remarkMarkAndUnravel] : []) | ||
| .use([remarkUnwrap, remarkEscape]); |
There was a problem hiding this comment.
All JSX or Astro component specific! Move under isMDX flag.
matthewp
approved these changes
Jul 21, 2022
natemoo-re
reviewed
Jul 21, 2022
This reverts commit 5572e8d.
bholmesdev
force-pushed
the
fix/use-set-html-for-non-mdx-markdown-renderers
branch
from
6244c67 to
96f04a6
Compare
natemoo-re
approved these changes
Jul 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
set:htmlfragment when themarkdown.modeconfiguration ismd. This prevents JSX expressions from getting parsed when users have opted out of "MDX mode."isMDXflagsetupandcomponentsin plain MD modeTesting
Test JSX expressions, components, and syntax highlighting ->
astro-markdown-md-mode.test.jsDocs
N/A! According to the docs, this is what
'md'mode always should've done.