Move getStaticPaths call to happen during generation #4047
Conversation
🦋 Changeset detectedLatest commit: 3d865dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
| const { astroConfig, logging, routeCache, ssr, viteServer } = opts; | ||
| if (!viteServer) throw new Error(`vite.createServer() not called!`); | ||
| const filePath = new URL(`./${route.component}`, astroConfig.root); | ||
| const mod = (await viteServer.ssrLoadModule(fileURLToPath(filePath))) as ComponentInstance; |
There was a problem hiding this comment.
this was the last ssrLoadModule call still happening during the build.
|
Ah, I'd hoped the breaking test was a small bug but it looks like its due to an actual regression. Probably due to a side-effect of changing the order that you build files in the |
|
Yeah, I think it's because |
Changes
getStaticPathsduring the build is moved to the end of the process, during page generation.vite.ssrLoadModuleanywhere in the build now. We are 100% completely static.getStaticPaths. Before this change if you use a Lit element in a page behind getStaticPaths you would get awindow is undefinederror. This was because getStaticPaths was being called upfront, when the renderer had not yet run, and therefore the shim was not applied. Now it happens as it should.Testing
Docs
N/A, bug fix.