Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDX + Tailwind, add support for injected page-ssr scripts to MDX extension #4050

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

FredKSchott
Copy link
Member

Changes

  • This is a short-term fix to add basic script injection handling to the MDX integration, to unblock MDX + Tailwind.
  • I call it short term because this is code that we've identified as a copy-paste risk that I've now pasted into a third place. On top of that, it is missing some logic to only inject the page script on MDX pages, and not non-page MDX files. That is considered a larger regression that will probably need a larger refactoring to solve for. In the meantime, this unblocks a v1.0 RC release.
  • With this I now see tailwind working with .mdx, .md (legacy), and .md (current)

Testing

  • Added a test.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: a3e2cae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@astrojs/mdx Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jul 26, 2022
@FredKSchott FredKSchott merged commit 9ab66c4 into main Jul 26, 2022
@FredKSchott FredKSchott deleted the mdx-tailwind branch July 26, 2022 04:26
@FredKSchott
Copy link
Member Author

Got @natemoo-re's +1 on Discord

@astrobot-houston astrobot-houston mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant