Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getViteConfig helper #4154

Merged
merged 13 commits into from
Aug 5, 2022
Merged

Add getViteConfig helper #4154

merged 13 commits into from
Aug 5, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Aug 4, 2022 •
edited
Loading

Changes

Testing

Tested manually

Docs

Future task

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5163938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) labels Aug 4, 2022
FredKSchott
FredKSchott reviewed Aug 4, 2022
View reviewed changes
packages/astro/src/compat/index.ts Outdated Show resolved Hide resolved
packages/astro/src/compat/index.ts Outdated Show resolved Hide resolved
@natemoo-re natemoo-re changed the title Add getVitestConfig helper Add getViteConfig helper Aug 5, 2022
@matthewp
Copy link
Contributor

matthewp commented Aug 5, 2022

Missing a changeset

@aFuzzyBear
Copy link
Contributor

Oh this looks really promising, cant wait for this

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 5, 2022
@natemoo-re natemoo-re force-pushed the feat/get-vite-config branch from c6cd625 to 5163938 Compare August 5, 2022 19:40
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Aug 5, 2022
@natemoo-re natemoo-re merged commit 36223f6 into main Aug 5, 2022
@natemoo-re natemoo-re deleted the feat/get-vite-config branch August 5, 2022 19:41
@kungpaogao
Copy link

yay!! thank you for adding this @natemoo-re

@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Merged
@natemoo-re
Copy link
Member Author

Of course @kungpaogao! We still have some work to do to make testing Astro components super easy, but this at least unblocks using Vitest for the other files in your project.

@screendriver screendriver mentioned this pull request Sep 28, 2022
Closed
1 task
@bluwy bluwy mentioned this pull request May 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott left review comments

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Installing vitest and writing test.ts files causes errors
5 participants
@natemoo-re @matthewp @aFuzzyBear @kungpaogao @FredKSchott