Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set up Preact DevTools in dev mode #4515

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

marvinhagemeister
Copy link
Contributor

Changes

This PR automatically sets up the bridge to Preact DevTools in the Preact integration when astro dev is run.

Testing

Browser extensions are very tricky to test automatically. So I mainly tested it locally in an astro starter project.

Screenshot:

Screenshot 2022-08-27 at 16 01 42

Docs

I don't think there is a need to add docs as it's kinda expected that DevTools works out of the box.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

🦋 Changeset detected

Latest commit: 160e184

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@astrojs/preact Minor
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/preact-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Aug 27, 2022
@marvinhagemeister
Copy link
Contributor Author

ping @FredKSchott @natemoo-re

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense, thanks!

@natemoo-re natemoo-re merged commit 999250d into withastro:main Sep 7, 2022
@astrobot-houston astrobot-houston mentioned this pull request Sep 7, 2022
@marvinhagemeister marvinhagemeister deleted the preact-devtools branch September 8, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants