Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update adapter READMESs to include astro add #4595

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

sarah11918
Copy link
Member

Changes

Updates all adapter package READMEs to include the astro add command. (Still keeps the manual instructions as an alternative.)

NOTE: Awaiting conclusion of discussion re: do we suggest installing with the --save-dev flag or not for the manual install instructions.

These docs currently do NOT suggest the flag (but, our current deploy docs do so we're discussing for consistency). This PR does NOT add the flag, so if its decided that we do want the flag shown, then we need to add that here.

Testing

No tests, Docs.

Docs

Only Docs here.
/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

⚠️ No Changeset found

Latest commit: 62b5275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 1, 2022
@sarah11918 sarah11918 mentioned this pull request Sep 1, 2022
29 tasks
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @sarah11918, I suggested a small fix, after this LGTM!

packages/integrations/cloudflare/README.md Outdated Show resolved Hide resolved
sarah11918 and others added 2 commits September 1, 2022 19:35
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@matthewp matthewp requested a review from a team as a code owner September 6, 2022 12:52
@matthewp matthewp merged commit 5231ec0 into main Sep 6, 2022
@matthewp matthewp deleted the astro-add-adapters branch September 6, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants