Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vueperslides to noExternal in vue integration #4639

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Add vueperslides to noExternal in vue integration #4639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-boats-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/vue': patch
---

Mark vueperslides as a default noExternal
6 changes: 4 additions & 2 deletions packages/integrations/vue/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { Options } from '@vitejs/plugin-vue';
import vue from '@vitejs/plugin-vue';
import type { AstroIntegration, AstroRenderer } from 'astro';
import type { UserConfig } from 'vite';
import vue from '@vitejs/plugin-vue';

function getRenderer(): AstroRenderer {
return {
Expand All @@ -10,7 +11,7 @@ function getRenderer(): AstroRenderer {
};
}

function getViteConfiguration(options?: Options) {
function getViteConfiguration(options?: Options): UserConfig {
return {
optimizeDeps: {
include: ['@astrojs/vue/client.js', 'vue'],
Expand All @@ -19,6 +20,7 @@ function getViteConfiguration(options?: Options) {
plugins: [vue(options)],
ssr: {
external: ['@vue/server-renderer'],
noExternal: ['vueperslides']
},
};
}
Expand Down