Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error handling more resilient in the dev server #4723

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Make error handling more resilient in the dev server #4723

merged 3 commits into from
Sep 12, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Added test case

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c9b6f9e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 12, 2022
Princesseuh
Princesseuh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matthewp matthewp merged commit 0dba3b6 into main Sep 12, 2022
@matthewp matthewp deleted the resilient-error-handling branch September 12, 2022 18:40
@astrobot-houston astrobot-houston mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal process gets terminated when a js/ts error occurs
2 participants
@matthewp @Princesseuh