Support Vite 3.1 #4752
Merged
Support Vite 3.1 #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60a1a59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Sep 14, 2022
matthewp
requested changes
Sep 14, 2022
|
do we still want to pin it to |
|
Let's try |
|
Updated to |
|
Looks like the new Vite types are messing with the Astro build. I reverted the Vite version bump at the meantime and we can probably tackle the types stuff in another PR. |
matthewp
approved these changes
Sep 14, 2022
Merged
matthewp
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Support Vite 3.1 * Update ~3.1.0 * Revert Vite bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While checking out #4727, I noticed that we're incorrectly accessing the
thiscontext in thehandleHotUpdatehook. This was previously the Vite plugin object, but was removed with the object hooks feature: vitejs/vite#9634 and vitejs/vite#9885Testing
Tested locally. This issue can be triggered when updating an Astro file. Ideally #4454 should cover this.
Docs
N/A. internal change.