Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override vite.build.target #4813

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Allow override vite.build.target #4813

merged 1 commit into from
Sep 20, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 20, 2022

Changes

Allow changing vite.build.target. The default is esnext, which the user may want to use es2020 instead.

I noticed it used to be es2020 but bumped in #2487. I think we should keep this value as baseline es2020 so that user can opt-in to advanced feature instead, but it would be a breaking change.

This may help similar issues to #4812 (but not completely as we don't have full legacy support)

Testing

N/A

Docs

N/A. I think this is a transparent change.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: a9e021b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 20, 2022
@matthewp matthewp merged commit be9eaa0 into main Sep 20, 2022
@matthewp matthewp deleted the override-build-target branch September 20, 2022 12:12
@astrobot-houston astrobot-houston mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants