GitHub Actions: add install action

[mrienstra]

Changes

• Add install action (installs pnpm, installs node, runs pnpm install)
• To reduce duplication
• Inspired by / based on withastro/docs .github/actions/install/action.yml
• Has 3 optional inputs:
  • node-version: string, defaults to 16, node semvar version
  • js-runtime: string, defaults to node, installs deno if deno is provided
  • install-dependencies: boolean string, defaults to true, skips pnpm install if false (if a boolean is passed, it will be coerced into a string before reaching .github/actions/install/action.yml)

Testing

Fingers crossed!

Docs

n/a

[changeset-bot]

⚠️ No Changeset found

Latest commit: f8aaeca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[matthewp]

This is really interesting! I didn't know you could break up actions like this.

[natemoo-re]

I love it and had no idea you could do this

[mrienstra]

I already noted that this was inspired by / based on withastro/docs, but more specifically, it was @hippotastic who authored withastro/docs#431, so props to you @hippotastic! 🌟💯

Minor detail that's on my mind, looking that this again:
I went with js-runtime with the thought that it would leave room for other JS runtimes, e.g. bun (and because it "felt wrong" to have a deno-specific argument that is only used once), but arguably it would be more intuitive to change that to install-deno (boolean, default false) instead, since currently, that maps better to the behavior. js-runtime having a default of 'node' implies that node will not be installed if another value is provided, which is not the case (node is always installed).
On the other hand, not very many people need to touch Astro's GitHub Actions, so... 🤷

[mrienstra]

Whoops, I was mixing up the types for actions & workflows -- I knew only the latter accepts (and requires) type:, but I had convinced myself the former still silently accepted multiple types, which in hindsight would be pretty weird. VS Code was telling me I was wrong, but I decided that just meant I needed to open an issue and/or PR on SchemaStore/schemastore src/schemas/json/github-action.json... 🤦

Anyhoo, I got to learn a bit about JSON Schema & whatnot, and I think I've got it (this PR) all squared away now, thanks to fromJson.

@natemoo-re, you might want to take another quick peek? Everything is the same except for .github/actions/install/action.yml. Extra credit: For future reference, in this scenario (you've approved, then I make changes), your preference would be:
🚀) "Re-request review" only
🎉) @ mention
👀) "Re-request review" & @ mention
😄) None of the above

[mrienstra]

Minor detail, but just in case: required defaults to false, so these 3 lines (7, 11, 15) could be removed. I put them in with the thought that it would be helpful to state this explicitly, but alternately there could be a comment between lines 4 & 5 saying something like "all of these are optional". And/or a comment could contain a link to the docs.

[natemoo-re]

I like having the default value here, even if it is implied.

[natemoo-re]

Looks great—nice updates! Thanks for being so thorough here!

[natemoo-re]

I like having the default value here, even if it is implied.