Add documentation for unknown errors #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
There was a problem hiding this comment.
Thanks @Princesseuh, great work tackling this. I have a small suggestion and then LGTM!
natemoo-re
approved these changes
Feb 17, 2023
| @@ -676,7 +734,7 @@ See https://docs.astro.build/en/guides/server-side-rendering/ for more informati | |||
| hint: 'See https://docs.astro.build/en/guides/content-collections/ for more on the `slug` field.', | |||
| }, | |||
|
|
|||
| // Generic catch-all | |||
| // Generic catch-all - Only use this in extreme cases, like if there was a cosmic ray bit flip | |||
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
yanthomasdev
approved these changes
Feb 17, 2023
liruifengv
pushed a commit
to liruifengv/astro
that referenced
this pull request
Feb 18, 2023
* feat(errors): Add documentation for unknown errors * docs(errors): Misc refactors * docs(errors): Remove unnecessary messages * docs(errors): Add guidance around UnknownError * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com> --------- Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We still generate docs links for unknown errors, so we should have documentation for them!
Testing
N/A
Docs
It's docs all the way down!
/cc @withastro/maintainers-docs for feedback!