Add a warning when using encoding in SSR and headers on objects in endpoints
#6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1946122 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
matthewp
approved these changes
Feb 24, 2023
natemoo-re
requested changes
Feb 27, 2023
natemoo-re
requested changes
Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Title is a mouthful. Basically,
encodingis only used to write the files when doing static generation, as such in SSR it doesn't do anything, but people expect it to affect the charset, but since #3841 we always default tocharset=utf-8. In the future, it would be much better if we only returned responses...The warning for headers is because returning an object with a certain type of body trips up TypeScript into thinking you're returning a Response since they're "compatible", so a small warning will help nudge users in the right direction.
Close #3841
Testing
N/A. Tested the warning manually
Docs
N/A