Add warning when using assets with non-node adapters #6533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f used with a non-Node adapter
🦋 Changeset detectedLatest commit: cda2102 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
commented
Mar 13, 2023
| @@ -28,6 +29,30 @@ export default function assets({ | |||
|
|
|||
| globalThis.astroAsset = {}; | |||
|
|
|||
| const UNSUPPORTED_ADAPTERS = new Set([ | |||
There was a problem hiding this comment.
It's okay for the error to be here, as this Vite plugin is only loaded when experimental.assets is enabled.
It's currently unclear if we'll add non-Node support before 3.0 (mostly depends on deps), but if we don't, we'll have to move this warning somewhere else where we have access to the Astro config, maybe in the astro:assets virtual module
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What the title says!
Closes #6529
Testing
N/A, just a warning
Docs
/cc @withastro/maintainers-docs for feedback!