fix(images): Improve error handling around the new assets feature #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a1e64e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
commented
Mar 27, 2023
| }, | ||
| schema, | ||
| { description: undefined } | ||
| { description: '__image' } |
There was a problem hiding this comment.
Unrelated bug fix. Since we resetted the description, the paths would always be relative to the first collection loaded instead of the one currently being rendered
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
|
Investigating a Windows thing... Not too sure of the cause. |
ematipico
approved these changes
Mar 28, 2023
sarah11918
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
I am loving all these error message PRs! 🥳
Thanks, @Princesseuh for being such a champion of these! I made some non-blocking suggestions for you, to use as you see fit!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds some more error handling around recently revamped features, notably Markdown (both frontmatter and content) will now error properly when images are not found.
This PR also does a very small logic fix to images in the frontmatter where images would sometimes be resolved from the wrong collection.
Testing
Added tests
Docs
cc @withastro/maintainers-docs ! Some new errors to look at in the classic
errors-data