Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose partytown config options from astro plugin #6667

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Expose partytown config options from astro plugin #6667

merged 1 commit into from
Mar 28, 2023

Conversation

thebinarymutant
Copy link
Contributor

@thebinarymutant thebinarymutant commented Mar 26, 2023

Changes

  • Allows developers to use the original properties defined by partytown

Testing

I didn't see any test's setup for the package. Do we need one?

Docs

Removed the content that explicitly mentioned about the debug and forward properties.

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2023

🦋 Changeset detected

Latest commit: 399b910

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 26, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice harmless change to me 👍

@thebinarymutant thebinarymutant requested a review from a team as a code owner March 27, 2023 17:45
@thebinarymutant
Copy link
Contributor Author

Thank you, @bluwy, for the review. I did change the doc and have squashed the history to make it cleaner. Happy with the current state of it, so, let me know if you need anything more from my side before the merge.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion

packages/integrations/partytown/src/index.ts Outdated Show resolved Hide resolved
Bump minor version

Remove unused import

docs

fix: use the nullish coalescing operator
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thebinarymutant, docs LGTM!

@bluwy bluwy merged commit aff53c1 into withastro:main Mar 28, 2023
@astrobot-houston astrobot-houston mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants