Fix image regeneration after changing image service #6680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I experienced very strange behaviour which resulted in images being rotated or not depending on how i change the widths or alt tags of images. I tracked this down to the image cache not being regenerated after i switched to sharp.
The behaviour of sharp differs in some ways. In my case sharp rotates the image while removing the exif data. squoosh does remove the exif data without rotating the images. When my image was the exact same image as before I got served the cached version built previously by squoosh so some images were still up side down etc. Changing the alt tag invalidated the cache, as it is used for hashing.
Testing
I did not add unit tests as my experience in this repo is very slim right now.
I verified that the behaviour is as intended by reproducing the mentioned behaviour manually.
Docs
Now the behaviour is as intended so i don't think with a fix like this we need any additional docs