Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change the external React docs page to https://react.dev #6690

Merged
merged 2 commits into from
Mar 28, 2023
Merged

docs: change the external React docs page to https://react.dev #6690

merged 2 commits into from
Mar 28, 2023

Conversation

cannibalhulk
Copy link
Contributor

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@cannibalhulk cannibalhulk requested a review from a team as a code owner March 28, 2023 13:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8794b1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Mar 28, 2023
yanthomasdev
yanthomasdev approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cannibalhulk, LGTM!

@cannibalhulk
Copy link
Contributor Author

LGTM!

@cannibalhulk
Copy link
Contributor Author

What should I do next? @Yan-Thomas

@yanthomasdev
Copy link
Member

What should I do next? @Yan-Thomas

With the PR? Well, just wait, someone else from our team will take a look and merge when it's fit 🙌

bholmesdev
bholmesdev approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am someone else from the team, and I approve this PR 👍

@bholmesdev bholmesdev merged commit d5bcf89 into withastro:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@bholmesdev bholmesdev bholmesdev approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cannibalhulk @yanthomasdev @bholmesdev