Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the actual error when there was an error while generating types #6762

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

Princesseuh
Copy link
Member

Changes

We previously swallowed the error message when there was an error while generating content collection types. This PR fixes that

Testing

Tested manually

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner April 5, 2023 14:42
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: 5139d2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 5, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally 👍

@Princesseuh Princesseuh merged commit 8b88e4c into main Apr 5, 2023
@Princesseuh Princesseuh deleted the feat/better-sync-error branch April 5, 2023 15:12
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed!

@astrobot-houston astrobot-houston mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants