Fix vercel edge private env vars #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6533d7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
matthewp
approved these changes
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6713
When building for Vercel edge with
ssr.target: 'webworker'in Vite, make sure Vite doesn't replaceprocess.envas({})so they work in Vercel edge runtime on deploy.cc @matthewp, didn't mean to steal your fix, but i was playing around some things while debugging it and found a fix 😬
Testing
Ran the issue's repro https://github.com/larryhudson/astro-vercel-edge-env-testing and run
MY_ENV_VAR=foo npm run buildto build it.After that, I open
.vercel/output/functions/render.func/chunks/pages/all.00bba6ec.mjsto verify that theMY_ENV_VARis correctly preserved asprocess.env.MY_ENV_VAR, not{}.MY_ENV_VAR.Docs
n/a. bug fix.