Inline process.env boolean values (0, 1, false, true)
#6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d870950 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Apr 25, 2023
ematipico
approved these changes
Apr 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
import.meta.envvalues were always rewritten toprocess.envvalues if possible. This caused a problem with feat(prerender): support quoted true / false values and 0 / 1 #6772 becauseimport.meta.env.PRERENDER_ENABLEDwas rewritten toprocess.env.PRERENDER_ENABLEDwhich was not statically analyzable.0,1,true, andfalseif possibleexport const prerender(cc @samducker) and can also improve dead code elimination in some scenarios.Testing
Tested manually because it relies on assigning to
process.envbefore running the build.Docs
As outlined in #6772, this is not a feature we want to explicitly document.