Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lit example to properly ignore error #6964

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

Princesseuh
Copy link
Member

Changes

Due to an upstream issue in the compiler (withastro/compiler#784), the TS pragma doesn't appear on the correct line in the generated TSX, so the comment didn't work. This PR updates the example with a temporary workaround in the meantime

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

⚠️ No Changeset found

Latest commit: 8215436

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label May 2, 2023
@Princesseuh Princesseuh merged commit 8dd43db into main May 2, 2023
@Princesseuh Princesseuh deleted the fix/lit-example branch May 2, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants