feat: cache assets in Vercel adapter #7412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: integration
bluwy
reviewed
Jun 19, 2023
| @@ -151,6 +151,11 @@ export default function vercelEdge({ | |||
| version: 3, | |||
| routes: [ | |||
| ...getRedirects(routes, _config), | |||
| { | |||
| src: '^/_astro/(.*)$', | |||
There was a problem hiding this comment.
The _astro path can be configured through build.assets, it would be nice to derive this string from that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add cache headers to assets in Vercel adapter's route config, following Vercel's default config.
This provides better config out of the box and is more consistent with static only builds, which uses Vercel's default config.
Testing
Before: assets are not cached
After: assets are strongly cached
Docs