Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: astro info command #7432

Merged
merged 8 commits into from
Jul 5, 2023
Merged

feat: astro info command #7432

merged 8 commits into from
Jul 5, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jun 20, 2023

Changes

Hackaton time!

This PR adds new command called astro info; it's a medium meant for:

  • users to share quickly their local environment, without typing too much in the bug report template (to update if this PR is accepted)
  • maintainers to have a predictable set of information that is standard across projects

For now, I printed only the info that we usually ask in the PR template, but we can print more :D

Testing

Not needed for now

Docs

Will include the team after feedback

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: b0ad3b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release labels Jun 20, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@delucis
Copy link
Member

delucis commented Jun 20, 2023

lol, why is called rage?? 😂

@ematipico
Copy link
Member Author

lol, why is called rage?? 😂

It's called rage because you usually use this command when everything goes wrong and you're upset! That's why rage 😃

@natemoo-re
Copy link
Member

This is great! Maybe astro info is a better command name? But we could definitely keep astro rage as an alias 😅

@ematipico ematipico changed the title feat: astro rage command feat: astro info command Jun 21, 2023
@ematipico ematipico force-pushed the feat/rage-command branch from a07280d to c7a0e4a Compare June 21, 2023 08:42
@ematipico
Copy link
Member Author

ematipico commented Jun 21, 2023

Renamed the command 😢

Screenshot 2023-06-21 at 09 43 12

Here's the final result

@sarah11918
Copy link
Member

Reminder to add docs here! https://docs.astro.build/en/reference/cli-reference/

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! I suppose we also want to update the issue template when this gets released.

@ematipico ematipico force-pushed the feat/rage-command branch from 053c19d to a0b53a4 Compare June 30, 2023 14:45
@ematipico
Copy link
Member Author

I added "Platform" and "Architecture" to the list of information returned

@sarah11918
Copy link
Member

Just checking up on docs for this! I didn't notice anything PR'd to the CLI reference page.

@ematipico
Copy link
Member Author

Just checking up on docs for this! I didn't notice anything PR'd to the CLI reference page.

Going to create a PR for that

'astro': minor
---

Adds a new command `astro info`, useful for sharing debugging information about your current environment when you need help!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adds a new command `astro info`, useful for sharing debugging information about your current environment when you need help!
Environment info in your CLI
Adds a new command `astro info`, useful for sharing debugging information about your current environment when you need help!

Just adding something that will become a heading here, since I think this will end up in the blog post draft, and the existing line would be too long.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with Chris, I'm not sure about updating the changeset here! 😅

This is a good changeset for the changelog, but not for the blogpost. So, I'm not sure whether to do any optimizing here at all, since there's no good choice.

As a default, I'll NOT suggest headings and stuff, only edit for typos etc., and let Matthew battle that when it comes blog post time! In which case, this one is fine as is!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bother :) fee free to merge any suggestion you deem right

@ematipico ematipico force-pushed the feat/rage-command branch from d8613af to e86182d Compare July 5, 2023 13:33
@ematipico ematipico merged commit 6e9c295 into main Jul 5, 2023
@ematipico ematipico deleted the feat/rage-command branch July 5, 2023 16:02
@astrobot-houston astrobot-houston mentioned this pull request Jul 5, 2023
matthewp pushed a commit that referenced this pull request Jul 11, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants