Refactor SSRResult and RenderContext
#7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the `scope` isn't used anywhere - `renderHead` and `maybeRenderHead` can return the instructions directly as the renderer can handle when to render head itself
This makes it easier to follow what configurations are required or not.
🦋 Changeset detectedLatest commit: f8d0bdc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
the
pkg: integration
|
Pushed a commit to fix a markdoc fail. It's sort of a breaking change, but I feel like it's an internal API which would've been hard to refactor if we don't change this. |
matthewp
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SSRResult._metadataonly contain ephemeral and mutable stateI made isolated commits that can be reviewed individually. But the whole changes aren't too big either.
Testing
Existing tests should pass
Docs
n/a. internal refactor.