Fix cloudflare runtime env var handling #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe53ba1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
ematipico
approved these changes
Jul 17, 2023
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up from #7651 (comment)
Fix #7137
Fix cloudflare runtime env var handling. We're using Vite's
ssr.target = 'webworker'config, and it's converting ourprocess.env.RUNTIME_VARto({}).RUNTIME_VAR, causing it to not work.This also tweaked Astro's env handling for the
PRERENDERtest, as it's indirectly passing with the bug above. Since it was passed a boolean value, I had to updatevite-plugin-envto handle it too.Testing
Un-skipped a test that revealed this bug.
Docs
n/a. bug fix.