Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astro:beforeload event #7823

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add astro:beforeload event #7823

merged 4 commits into from
Jul 27, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 26, 2023

Changes

  • Fixes View Transition resets html attributes #7765
  • astro:beforeload fires immediate after the document has been swapped. This gives the page a chance to update its state; such as setting classes.
  • Fixes the dark-mode use case

Testing

  • New test added

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: a268ea1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 26, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs in the docs repo LGTM, added a small nit for the changeset

.changeset/chilled-elephants-develop.md Outdated Show resolved Hide resolved
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@matthewp matthewp merged commit 5161cf9 into main Jul 27, 2023
13 checks passed
@matthewp matthewp deleted the vt-dark-mode branch July 27, 2023 12:57
@astrobot-houston astrobot-houston mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Transition resets html attributes
4 participants