Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video persistence regression #8271

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix video persistence regression #8271

merged 2 commits into from
Aug 29, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 29, 2023 •
edited
Loading

Changes

  • Previous swap order was causing videos to reset.

Testing

  • Manual. We have a test that should have failed before. After this is released I'll work on fixing that test.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 67776fd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 29, 2023
@matthewp matthewp marked this pull request as ready for review August 29, 2023 19:33
natemoo-re
natemoo-re approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually checked with my local unmount test, still works!

LGTM.

@matthewp matthewp merged commit 16f09df into main Aug 29, 2023
@matthewp matthewp deleted the persist-swap-order branch August 29, 2023 19:46
@astrobot-houston astrobot-houston mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @natemoo-re