chore(core): improve the logging of assets feature #8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db9058f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Sep 22, 2023
sarah11918
reviewed
Sep 22, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
approved these changes
Sep 22, 2023
alexanderniebuhr
changed the title
alexanderniebuhr
deleted the
alexanderniebuhr-improve-assets-logging
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing a lot of confusion about the
nooplogging. This issue has come up multiple times on Discord already (e.g., Discord link). I believe we should adjust the logging to avoid confusing users.Changes
validateAssetsFeatureassetsfeature is unsupportedsharporsquooshincompatibility. Since we automatically replace these withnoop, the user shouldn't need to make any manual changes; therefore, an error is too severe.noopFor more details, see self-review comments
Docs
/cc @withastro/maintainers-docs for feedback!