Added OUTPUT dir to sitemap build command #8824
Conversation
🦋 Changeset detectedLatest commit: 6d39c91 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
| @@ -177,7 +177,7 @@ const createPlugin = (options?: SitemapOptions): AstroIntegration => { | |||
| limit: entryLimit, | |||
| gzip: false, | |||
| }); | |||
| logger.success(`\`${OUTFILE}\` is created.`); | |||
| logger.success(`\`${OUTFILE}\` created at \`${fileURLToPath(dir)}`); | |||
There was a problem hiding this comment.
I think we can extract fileURLToPath(dir) as its own variable, and maybe we can also do path.relative(process.cwd(), destDir) so that the logged path is shorter?
There was a problem hiding this comment.
@bluwy updated.
|
As far as I can tell the failed test feels like a flake? Will check back when I update the PR |
|
@silent1mezzo No, we don't have many tests for the CLI, so a local test with possible snapshots is a very welcome alternative :) |
|
Thanks for picking up this suggestion @silent1mezzo! |
Changes
This changes the CLI output from
@astrojs/sitemap: 'sitemap-index.xml' is createdto@astrojs/sitemap: 'sitemap-index.xml' created at '{OUTPUT DIRECTORY}'Testing
The CLI output isn't tested anywhere (as far as I could tell).
Docs
The CLI output isn't mentioned in the docs (as far as I could tell) so there's nothing that needs updating.