Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): build config from astro conflict with vite.config.js #8852

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

rayriffy
Copy link
Contributor

Changes

  • configFile: false added to specifically tell Vite not to automatically find, read, and merge config from vite.config.js. which could conflict with Astro's vite config (docs)

fixes #8702

Testing

N/A

Docs

N/A. Docs already said in the way to modify Vite behavior via astro.config.mjs

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: b25ff18

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 17, 2023
@ematipico
Copy link
Member

@rayriffy I think you want to have the configuration here.

So it has effects on the dev server too.

@rayriffy
Copy link
Contributor Author

I agree, I forgot to trace back to see where the origin of common config itself is. Change has been revised.

@ematipico ematipico merged commit 2c18e2d into withastro:main Oct 18, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite.config.js gets used by astro... intentional?
3 participants